Use nearest relevant commit id based on path filters (fixes #643) #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Height calculations now keep track of nearest relevant commit (managed only for now). - VersionOracle uses the nearest relevant commit.
|
@AArnott I'm waiting for feedback on this before proceeding. Some libgit2-based tests currently fail because they intentionally throw |
|
Has this been implemented? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress for discussion. I've also been affected by #643 so I'm attempting a fix.
@AArnott I'd welcome comments on the general approach. I've implemented in managed only for now, plan to implement for libgit if/when the managed implementation is acceptable.
The basic idea is to leverage the work of
GitWalkTracker, keeping track of the commit with greatest height (which I believe should be the relevant commit nearest to the 'current' commit, and only commits that survive path filtering are tracked).Note the comment here - I don't have a deep enough understanding of this scenario to know what should be done.