Skip to content

Conversation

esther-anierobi
Copy link

Description

This PR solves the issue "Remove null values from CDS Hook API responses #142".

Related Issue

Remove null values from CDS Hook API responses #142

Changes Made

  • addedd exclude_none=True to model_dump() at healthchain/gateway/events/dispatcher
  • addedd exclude_none=True to model_dump() at /gateway/fhir/aio.py
  • addedd exclude_none=True to model_dump() at healthchain/gateway/fhir/base.py
  • addedd exclude_none=True to model_dump() at healthchain/interop/generators/cda.py
  • addedd exclude_none=True to model_dump() at tests/gateway/test_base_fhir_gateway.py
  • addedd exclude_none=True to model_dump() at tests/gateway/test_event_dispatcher.py

Testing

  • By running poetry run pytest
  • Buy doing `pre-commit run --all-files

Checklist

  • [x ] I have read the contributing guidelines
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

Copy link
Contributor

@adamkells adamkells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the effort on this! Just two things:

  1. It looks like you committed the .idea folder from your IDE by mistake, can you remove this?
  2. The issue had a script to run for confirming that the changes are correct, (it's the very last line) can you trying running that also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants