perf: optimize image processing with larger pixel chunks#27
Merged
doprz merged 3 commits intodoprz:mainfrom Apr 25, 2025
Merged
perf: optimize image processing with larger pixel chunks#27doprz merged 3 commits intodoprz:mainfrom
doprz merged 3 commits intodoprz:mainfrom
Conversation
Contributor
Author
|
Bumped dependency versions and updated Didn't find any performance regressions when running with .jpeg inputs. |
Owner
|
Thank you for another PR @CordlessCoder , it is very much appreciated! |
Contributor
Author
|
The PR is ready to merge btw. |
doprz
reviewed
Apr 25, 2025
doprz
approved these changes
Apr 25, 2025
Owner
There was a problem hiding this comment.
LGTM!
Thank you once again for another PR @CordlessCoder !
Here are some of my thoughts:
- Increasing the chunk size from 4 to 4096 should significantly improve performance by:
- Enhancing cache locality
- Reducing threading overhead per pixel
- Allowing better SIMD optimization opportunities (in the future)
- How does this handle images whose dimensions aren't evenly divisible by the chunk size? The
chunks_exact_mutwill process complete chunks, but we might need to handle remaining pixels.
Contributor
Author
There are no remaining pixels, it uses .par_chunks_mut - not .par_chunks_exact_mut. |
Owner
|
Thank you for clarifying that; I will be updating the docs, nix flake, and possibly finish #25 for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeing a ~2x speedup thanks to this :)