Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(molokai): line-number distant-fg - change nil -> 'unspecified #821

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(molokai): line-number distant-fg - change nil -> 'unspecified #821

merged 1 commit into from
Jul 2, 2024

Conversation

carlosgeos
Copy link
Contributor

@carlosgeos carlosgeos commented Feb 17, 2024 •
edited
Loading

Similar to #818. Removes the warnings:

Warning: setting attribute ‘:distant-foreground’ of face ‘line-number-current-line’: nil value is invalid, use ‘unspecified’ instead.
Warning: setting attribute ‘:distant-foreground’ of face ‘line-number’: nil value is invalid, use ‘unspecified’ instead.

Partially fixes #793, Molokai was at least mentioned on this comment #793 (comment)

  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.
  • I am blindly checking these off.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

@hlissner hlissner added is:bug Something isn't working as intended theme:molokai labels Jul 1, 2024
@hlissner hlissner added this to the v2.4.0 milestone Jul 1, 2024
@hlissner hlissner merged commit 8790d38 into doomemacs:master Jul 2, 2024
@hlissner
Copy link
Member

hlissner commented Jul 2, 2024

Good catch. Thanks for your help!

hlissner added a commit that referenced this pull request Jan 10, 2025
@hlissner
fix: support deftheme plist & replace nil w/ unspecified
b668cbb 
Adds support for specifying :family and :background-mode, and specifies
:kind 'color-scheme by default.

Also replaces any `nil` value with `unspecified` to prevent 'nil value
is invalid' warnings and simplify our theme spec.

Fix: #821
hlissner added a commit that referenced this pull request Jan 12, 2025
@hlissner
fix: 'wrong-type-argument listp unspecified' error
e506a87 
The substitution wasn't applied deep enough in the face specs. Plus
saves on some allocations to modify SPECS in-place.

Fix: #852
Ref: #821
Amend: b668cbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlissner hlissner hlissner approved these changes

Assignees
No one assigned
Labels
is:bug Something isn't working as intended theme:molokai
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Warning: nil value is invalid, use ‘unspecified’ instead
2 participants
@carlosgeos @hlissner