Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last table offset add length over file length #107

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Xxx-Bin
Copy link
Contributor

@Xxx-Bin Xxx-Bin commented Feb 12, 2022

subheader length add 2 times

subheader length add 2 times
@bsweeney bsweeney modified the milestones: 0.5.4, 0.5.5 Feb 12, 2022
@bsweeney
Copy link
Member

Noting for reference, this subtable logic performs the following:

  • write header
  • write content
  • calculated subtable length and add the value to the header
  • seek back to the header start
  • overwrite header with fully populated value
  • seek to the position after the table end

We do not need to record the length on the second write because it's overwriting the existing header.

@bsweeney bsweeney merged commit 0deb407 into dompdf:master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants