This repository was archived by the owner on Dec 6, 2018. It is now read-only.
fix prefix in streams by using a streams2 transform.#43
Open
juliangruber wants to merge 2 commits intodominictarr:masterfrom
Open
fix prefix in streams by using a streams2 transform.#43juliangruber wants to merge 2 commits intodominictarr:masterfrom
juliangruber wants to merge 2 commits intodominictarr:masterfrom
Conversation
Owner
|
I think there is a better way to fix this, |
Contributor
Author
|
But what was the problem on 0.8 then? |
Owner
|
it's about the changing ways that readable-stream's classic streams polyfil worked. if it's a non-core (ie, from the isaacs/readables-stream) in 0.8 then it works a different way to what it works now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #42
deps are bigger but it's less hacky / likely to break and fixes the tests in node 0.8