Skip to content
This repository was archived by the owner on Dec 6, 2018. It is now read-only.

fix prefix in streams by using a streams2 transform.#43

Open
juliangruber wants to merge 2 commits intodominictarr:masterfrom
juliangruber:fix-read-stream
Open

fix prefix in streams by using a streams2 transform.#43
juliangruber wants to merge 2 commits intodominictarr:masterfrom
juliangruber:fix-read-stream

Conversation

@juliangruber
Copy link
Contributor

fixes #42

deps are bigger but it's less hacky / likely to break and fixes the tests in node 0.8

@dominictarr
Copy link
Owner

I think there is a better way to fix this,
if you just use on('data' as well as wrap read.
I think it currently checks for .read and wraps that,
but if it's not there it assigns a data listener.
One simple way would be to wrap emit and if it's emit('data',...) then fix the key.

@juliangruber
Copy link
Contributor Author

But what was the problem on 0.8 then?

@dominictarr
Copy link
Owner

it's about the changing ways that readable-stream's classic streams polyfil worked.

if it's a non-core (ie, from the isaacs/readables-stream) in 0.8 then it works a different way to what it works now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

readable-stream update in levelup to 1.1.x has broken level-sublevel in node v0.8.x

2 participants