Skip to content

Conversation

@maraspr
Copy link
Contributor

@maraspr maraspr commented Jan 8, 2026

Fix for errors in parsing b64-strings caused by PR-648.
This removes newlines before trying b64decode, since b64decode with validate=True does not accept any characters that are not in the base64 alphabet (even newlines).

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.00%. Comparing base (f618f69) to head (87ebbdb).
⚠️ Report is 251 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   58.39%   60.00%   +1.61%     
==========================================
  Files          12       12              
  Lines        1620     2038     +418     
==========================================
+ Hits          946     1223     +277     
- Misses        674      815     +141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seanthegeek seanthegeek merged commit 343b53e into domainaware:master Jan 8, 2026
7 checks passed
seanthegeek added a commit that referenced this pull request Jan 8, 2026
Validate that a string is base64-encoded before trying to base64 decode it. (PRs #648 and #649)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants