Fix logging configuration not propagating to child parser processes #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging configuration in
cli.pyonly applied to the main process. Child processes spawned viamultiprocessing.Processinherited only theNullHandler, suppressing all warnings and errors from parsing operations.Changes
Added
_configure_logging(log_level, log_file=None)helper - Configures logging handlers in any process with the same formatter and file output as the parentUpdated
cli_parse()signature - Acceptslog_levelandlog_fileparameters, calls_configure_logging()on entry to set up logging in child processModified Process creation - Captures and passes
logger.levelandopts.log_filefrom parent to child processesExample
Before this change, DNS warnings in child processes were invisible:
After this change, all logging configuration propagates:
The fix uses exact type checking (
type(h) is logging.StreamHandler) to distinguish StreamHandler from FileHandler subclass, and catches specific file I/O exceptions rather than bareException.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
1.0.0.1REDACTED, pid is -1(packet block)1.1.1.1REDACTED, pid is -1(packet block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.