Skip to content

Allow setHeader and resp with headers to be used in the same handler #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2022
Merged

Allow setHeader and resp with headers to be used in the same handler #300

merged 1 commit into from
Jul 18, 2022

Conversation

@iffy
Copy link
Contributor

@iffy iffy commented Jul 18, 2022

Supersedes #294 with the minimal change needed to accomplish the fix.

@iffy iffy mentioned this pull request Jul 18, 2022
Closed
dom96
dom96 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Owner

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thank you!

@dom96 dom96 merged commit 072ef26 into dom96:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dom96 dom96 dom96 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iffy @dom96