CI: build arm64 images #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to resolve: panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt Solution from: golangci/golangci-lint#2374
Temporarily disable: - G114: Use of net/http serve function that has no support for setting timeouts https://github.com/securego/gosec#annotating-code
Github Actions image builds for arm64 are failing because the lint step (Makefile:87) can take longer than 5 minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very useful project, thanks for publishing this!
I added arm64 images to the github workflow, and also bumped a few dependencies to make the build succeed. This is tested and works on the
t2ainstance type.Building cross-architecture does take significantly longer (might be improved w/experimentation), and I understand it may introduce additional maintenance that isn't useful to you if you don't use ARM instances, so no worries if you don't care to merge all of this. Feel free to let me know if you prefer only a subset of my proposed changes, or for me to maintain this as a fork.