-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add build & runtime debug logging #1321
Conversation
@rakannimer I struggle to run the e2e tests in dev mode on my machine. Do i need to start the basic example as server or sth? |
It looks like the props are not being rendered properly in the basic example, it seems something broke in the docz package here : https://github.com/doczjs/docz/pull/1321/files#diff-5cc2196461930cb24939fb44764d656bL121 How are e2e-tests failing on your setup ? Did you try running yarn packages && node other-packages/e2e-tests/index.js You can also try running the basic example with the dev-env by running : yarn
cd dev-env/basic
yarn
node dev.js The alert props should be missing if the test output is correct. |
Both fail 😅
|
when executing
|
Could you pull from master and try running the dev-env again ? There was an outdated dependency that should be fixed now. Not sure what's happening when you're running e2e-tests 🤔 |
86053a4
to
d7bb104
Compare
Nice thanks! The basic demo is running now! Can reproduce the issue. Will check and push a fix :) |
d7bb104
to
cabd1c0
Compare
debug(keys) | ||
|
||
const found = keys.find(key => { | ||
return !!matchingPatterns.find(pattern => key.includes(pattern)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CircleCI is probably breaking here. I would recommend checking the PR again and analyzing where exactly it is breaking.
Hey there. I moved on and I am no more using docz in my projects. Therefore I have no time to work on this PR anymore. Feel free to take it over, otherwise just close it |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Adds support for the debug module to the project.
Via
DEBUG=docz*
you now get:It simplifies the component matching in the Props component as well.
Post merge todos: