This fix replaces jazzlib with zip4j #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the codebase to utilize Zip4j instead of Jazzlib for handling zip files, enhancing functionality and reliability. It includes changes in dependency addition and modifications across several files to adapt to the new library, ensuring compatibility and fixing related test expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #7
It seems that zip4j is much more capable of handling zip archives. It behaves slightly differently when working with
ZipInputStreamcreated not from a.zipfile, but the difference is subtle and shouldn't really affect many clients. However, it might be considered as functionally incompatible.