Skip to content

Use the wp_parse_args() helper to merge the args. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whyisjake wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use the wp_parse_args() helper to merge the args. #50

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4838bcf
Use the `wp_parse_args()` helper to merge the args.
whyisjake Dec 5, 2016
54967ed
Swap the args.
whyisjake Dec 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion documentcloud.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ function prepare_oembed_fetch( $provider, $url, $args ) {
// Merge actual args with default attributes so that defaults are always
// sent to oEmbed endpoint
$default_atts = $this->get_default_atts();
$atts = array_merge( $default_atts, $args );
$atts = wp_parse_args( $default_atts, $args );
Copy link

@reefdog reefdog Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @whyisjake. Seems like the param order needs to be reversed though?

Copy link
Author

@whyisjake whyisjake Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, lemme update.


// Some resources (like notes) have multiple possible
// user-facing URLs. We recompose them into a single form.
Expand Down