Removing the Rails Controller and refactor into middleware #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using Rack middleware, we would allow easier integration of Jammit into non-Rails projects and addresses #161
The basic approach here is using a Rack::Request and extract path_info from there, package the assets with Jammit, and wrap it into a Rack::Response.
I was looking into Rack::Sprockets and Warden for some inspiration on the topic (incl. use of RSpec).
It would be great to hear your feedback what you think.
My first thought was also to rename the Controller into Manager or Packager, to avoid confusion with a Rails or Backbone controller.
The request-response can be tested with: