Reorganize read-only class check in UnitOfWork #12229
Open
+33
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, calling
computeChangeSetsand thereafter trying to rely onisReadOnlydoes not work as expected. The state ofreadOnlyObjectsinternally did not sufficiently get updated. Thereby public methodisReadOnlyis not as reliable as expected.This PR moves the check for read-only classes to a different location in the code to improve reliability of
isReadOnly.Taking the metadata to userland in order to check for a class to be readonly is not preferable, especially as
computeChangeSetsalready is iterating over the metadata and entity objects.Expected behavior
Being able to reliably use
isReadOnlyto throw an exception in userland when a write to an entity is expected while these values won't be committed / flushed by the orm.