BUGFIX: prevent creating new alias for columns after filters changed #12228
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue 12225
When there is a oneToMany relation where the children use single table inheritance, if the relation is re-fetched after a filter changed,
SingleTablePersister::getSelectColumnsSQLwill generate new aliases for the child entity fields. ThenResultSetMapping::addIndexBypicks the first alias that matches theindexByfield, which doesn't exist in the updated list. This causes ObjectHydrator:502 to throw anErrorException: Warning: Undefined array keyThis PR prevent creating new aliases.
The change is inspired by the code in
BasicEntityPersister::getSelectColumnSQLwhich reuses the aliases that already exist.