Fix no-op for initializeObject() and isUnitializedObject() when object is not a mapped entity #12173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is not a mapped entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix initializeObject() and isUnitializedObject() to be no-op for non-managed objects with native lazy objects
This fix wraps
getClassMetadata()calls in try/catch blocks to handle non-entity objects gracefully while preserving functionality for valid Doctrine entities (including detached ones afterclear()).I went with the try/catch approach since
isInIdentityMap()also internally callsgetClassMetadata(), but I'm open to better solutions if there are any.Changes:
UnitOfWork::initializeObject(): Add try/catch around metadata accessUnitOfWork::isUninitializedObject(): Add try/catch around metadata accessFixes #12172