fix: handle DateTime, arrays, and nulls properly in value comparison #12066
+74
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new private method `valuesAreEqual` in UnitOfWork to perform value comparisons. - This method correctly compares null values, DateTimeInterface instances (using the spaceship operator), and arrays recursively to ensure deep equality. - Replaced existing strict equality checks (===) with `valuesAreEqual` in change detection logic. - Added recursive array comparison method `arraysAreEqual` to verify keys and values match exactly. - These changes prevent false positives in Doctrine change tracking caused by naive comparisons. - Improves accuracy and stability in detecting entity changes, especially for date and array fields.
|
May you provide some test, where the uow doesn't detect changes or it detect changes that aren't changes and that are covered by your code now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch Summary
This patch improves the value comparison logic in Doctrine’s
UnitOfWorkclass during change detection.Key Changes
Introduces a private method
valuesAreEqual()that compares values with special handling for:nullvalues,DateTimeInterfaceinstances using the spaceship operator (<=>),===) for other types.Replaces existing strict equality checks with
valuesAreEqual()to prevent false positives.Benefit
Enhances reliability in detecting changes for entities with
DateTimeand array fields.