Remove sql executor #12052
Draft
Remove sql executor #12052
+1
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Jul 1, 2025
| * | ||
| * @link www.doctrine-project.org | ||
| */ | ||
| class SingleSelectExecutor extends AbstractSqlExecutor |
There was a problem hiding this comment.
@mpdude should this class be deprecated on 3.6.x?
greg0ire
commented
Jul 1, 2025
| @@ -77,8 +76,6 @@ public function testUnserializeSingleSelectResult(string $serialized): void | |||
| $this->assertInstanceOf(ParserResult::class, $unserialized); | |||
| $this->assertInstanceOf(ResultSetMapping::class, $unserialized->getResultSetMapping()); | |||
| $this->assertEquals(['name' => [0]], $unserialized->getParameterMappings()); | |||
| $this->assertInstanceOf(SingleSelectExecutor::class, $unserialized->getSqlExecutor()); | |||
| $this->assertIsString($unserialized->getSqlExecutor()->getSqlStatements()); | |||
There was a problem hiding this comment.
I'm not sure what these assertions should be replaced with. If there is something, maybe that something should be used on 3.x already.
greg0ire
commented
Jul 1, 2025
| $query->setQueryCache($cache); | ||
|
|
||
| $query->getResult(); | ||
| } |
There was a problem hiding this comment.
I think maybe this should be rewritten on 3.x to avoid calling setSqlExecutor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #11188