Fix ClassMetadata::fullyQualifiedClassName

[WinterSilence]

Fix for cases like as:
entity class in namespace X, listener class in global namespace and passed as ::class constant (#[\Doctrine\ORM\Mapping\EntityListeners([\ProductImageFile::class])]). In this case PHP convert class name to ProductImageFile when pass to EntityListeners::__construct().

[greg0ire]

This should come with a test, and shouldn't break existing tests

[WinterSilence]

@greg0ire

and shouldn't break existing tests

it's not possible, I can only update existed tests

[WinterSilence]

@greg0ire tests extended and fixed

[greg0ire]

tests extended and fixed

On top of this, you should create an entirely new test function showcasing the use case you described in your PR description. It might help me understand what this is all about (I must admit it's not entirely clear right now).

[WinterSilence]

@greg0ire

I must admit it's not entirely clear right now

I post full case here:

<?php
namespace Entities;

#[\Doctrine\ORM\Mapping\Entity]
#[\Doctrine\ORM\Mapping\Table(name: 'product_images')]
#[\Doctrine\ORM\Mapping\EntityListeners([\ProductImageFile::class])]
class ProductImage
{
   ...
}

<?php
class ProductImageFile
{
    ...

    #[\Doctrine\ORM\Mapping\PostRemove]
    public function onRemoveEntity(\Entities\ProductImage $productImage): void
    {
        $this->deleteFile($productImage);
    }
}

When PHP create instance of #[\Doctrine\ORM\Mapping\EntityListeners([\ProductImageFile::class])], passed listener class converted to ProductImageFile. Entity class in namespace Entities and ClassMetadata::fullyQualifiedClassName() convert class name to Entities\ProductImageFile, this class not exists and it's throw exception at execution. I.e. ClassMetadata::fullyQualifiedClassName() may generates not existed class names.

[WinterSilence]

@greg0ire PR updated. I don't think it's BC, because not existed class couldn't be created later.

[greg0ire]

If you don't think it's a breaking change, then why are you targeting 4.0.x?

[greg0ire]

I post full case here:

You should probably create a functional test case of that.

[WinterSilence]

@greg0ire

If you don't think it's a breaking change, then why are you targeting 4.0.x?

It's not critical problem, but I want to fix it in future versions

You should probably create a functional test case of that.

It's hard to reproduce in test - I still learn Doctrine. testFullyQualifiedClassNameNotAppendNamespaceToClassInGlobalNamespace cover all same cases