-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide forward-compat replace for doctrine/{event-manager,persistence,reflection} #843
Conversation
Hmm, not sure if this is gonna work. 🤔 |
Did some testing locally and it seems fine. 👍 Let's wait for @Ocramius to possibly spot some dragons. |
Hmm. @Majkl578, did you also check |
I tried
Hmm, that's to avoid 1.1-2.0 simultaneously which could, according to semver, contain some new features that Common wil no longer be able to provide.
Agreed, anyone volunteers for the job? 😊 |
@Majkl578 |
that might be much easier actually. Version numbers are free. Releasing |
40621d0
to
0f9c25e
Compare
Updated to also include doctrine/persistence and doctrine/reflection. 2.9.0 will not include any of these three packages. |
AFAIK, these 3 packages are ready. So I'd rather release them and move forward to 2.9.0 already, without messing up with |
Yes, the plan is to release 2.9.0 in upcoming days (once #845 is resolved) and then, should there be some issues with upgrading (i.e. some combinations like DBAL 2.8 + ORM 2.6 + Symfony 3.x), we can consider this PR. For now I'll leave it open and we'll see. |
0f9c25e
to
ec367de
Compare
I think the transition in 2.9.0 went well and without any major issues, so this can now be closed. |
This should allow us to depend on
doctrine/event-manager
package while still usingdoctrine/common
2.8.x (thus not requiring immediate release of 2.9, which should be done once we solvedoctrine/persistence
).This is targetting 2.8 only, not applicable in 2.9.x-dev (#842 will be done instead).
Once
doctrine/common
2.9.0 is out, real dependency kicks in.@Ocramius Does this make sense as forward compatible polyfill? doctrine/event-manager is identical.