Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against PHP 8 #1172

Merged
merged 1 commit into from
May 25, 2020
Merged

Test against PHP 8 #1172

merged 1 commit into from
May 25, 2020

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented May 25, 2020

This PR:

  • allows installing the bundle on PHP 8
  • runs tests against PHP 8, allowing failures for the time being.

@alcaeus alcaeus added this to the 1.12.10 milestone May 25, 2020
@alcaeus alcaeus self-assigned this May 25, 2020
@alcaeus alcaeus requested a review from greg0ire May 25, 2020 19:26
@greg0ire
Copy link
Member

greg0ire commented May 25, 2020 •
edited
Loading

The tests show a Fatal Error:

.PHP Fatal error:  Declaration of Doctrine\DBAL\Driver\PDOConnection::query() must be compatible with PDO::query(string $statement) in /home/travis/build/doctrine/DoctrineBundle/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php on line 73

Fatal error: Declaration of Doctrine\DBAL\Driver\PDOConnection::query() must be compatible with PDO::query(string $statement) in /home/travis/build/doctrine/DoctrineBundle/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php on line 73

Are there signature changes in PDO 😱 ?

Should put this on hold until resolved? Looks like we will need a (big?) change in the DBAL because of this.

@alcaeus
Copy link
Member Author

alcaeus commented May 25, 2020

I believe DBAL will only support this in 3.0. We can focus on that later when stabilising tests 👍

@alcaeus alcaeus merged commit 2ee4c25 into doctrine:1.12.x May 25, 2020
@alcaeus alcaeus deleted the php-8 branch May 25, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@alcaeus alcaeus

Labels
CI Improvement
Projects
None yet
Milestone
1.12.10
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaeus @greg0ire