cblite 3.2.2 update: New logging API #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyMasson
approved these changes
Apr 17, 2025
corentinmb
reviewed
Apr 17, 2025
| @@ -11,6 +11,7 @@ keywords = ["couchbase"] | |||
| categories = ["database"] | |||
|
|
|||
| [dependencies] | |||
| bitflags = "2.9.0" | |||
There was a problem hiding this comment.
PR review help: New dependency to implement bit masks (we need to map to a CBlite C structure that create bit mask to concatenate domains to log, see
couchbase-lite-rust/libcblite_community/include/cbl/CBLLogSinks.h
Lines 50 to 61 in 3ffe3a4
| log_sink.level = kCBLLogDebug; | ||
| log_sink.domains = kCBLLogDomainMaskAll; | ||
|
|
||
| CBLLogSinks_SetConsole(log_sink); |
There was a problem hiding this comment.
PR review help: Just for testing...
| level: log_sink.level as u8, | ||
| callback: Some(invoke_log_callback), | ||
| domains: log_sink.domains.bits() as u16, | ||
| }) |
There was a problem hiding this comment.
PR review help: implementation of CBLite C lib (thanks to bindings), more info in
Line 126 in 36a9151
| $crate::logging::Domain::Database, $crate::logging::Level::Debug, | ||
| format_args!($($arg)*))); | ||
| } | ||
|
|
There was a problem hiding this comment.
PR review help: Removed because useless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Logging API
Couchbase Lite 3.2.2 introduces a new Logging API. The new Logging API has the following benefits: