Allow configuration through argument list (in addition to string) #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Howard <[email protected]>
xenoscopic
commented
Jun 26, 2025
Comment on lines
+33
to
+34
| ContextSize int64 `json:"context-size,omitempty"` | ||
| RuntimeFlags []string `json:"runtime-flags,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
I don't know if this JSON nomenclature is used anywhere (I couldn't find it), but I've tried to make it consistent before it becomes used anywhere.
doringeman
approved these changes
Jun 27, 2025
Contributor
doringeman
left a comment
doringeman
left a comment
There was a problem hiding this comment.
LGTM!
(Don't we usually use snake case for JSON keys?)
Contributor
Author
|
I don't think there's a strong Docker convention on the JSON keys (Docker API, Compose, et al. all look different). Right now we've already released provider support with config in Docker CE, so I think we have to leave the keys as is for now 😞 |
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Oct 2, 2025
Fix install race detection using more tolerant polling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll allow runtime flag configuration via either an explicit, pre-parsed list (via
runtime-flags) or via a string (viaraw-runtime-flags). This will support the Composemodels:spec as well as the Composemodelprovider, respectively.