Skip to content

scheduler: move OpenAI recording after runner load/release #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doringeman merged 1 commit into from
Jun 27, 2025
Merged

scheduler: move OpenAI recording after runner load/release #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/inference/scheduling/scheduler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,14 +238,6 @@ func (s *Scheduler) handleOpenAIInference(w http.ResponseWriter, r *http.Request
s.tracker.TrackModel(model)
}

// Record the request in the OpenAI recorder.
recordID := s.openAIRecorder.RecordRequest(request.Model, r, body)
w = s.openAIRecorder.NewResponseRecorder(w)
defer func() {
// Record the response in the OpenAI recorder.
s.openAIRecorder.RecordResponse(recordID, request.Model, w)
}()

// Request a runner to execute the request and defer its release.
runner, err := s.loader.load(r.Context(), backend.Name(), request.Model, backendMode)
if err != nil {
Expand All @@ -254,6 +246,14 @@ func (s *Scheduler) handleOpenAIInference(w http.ResponseWriter, r *http.Request
}
defer s.loader.release(runner)

// Record the request in the OpenAI recorder.
recordID := s.openAIRecorder.RecordRequest(request.Model, r, body)
w = s.openAIRecorder.NewResponseRecorder(w)
defer func() {
// Record the response in the OpenAI recorder.
s.openAIRecorder.RecordResponse(recordID, request.Model, w)
}()

// Create a request with the body replaced for forwarding upstream.
upstreamRequest := r.Clone(r.Context())
upstreamRequest.Body = io.NopCloser(bytes.NewReader(body))
Expand Down