Respect context size from model config #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Emily Casey <[email protected]>
ekcasey
commented
Jun 27, 2025
xenoscopic
reviewed
Jun 27, 2025
Comment on lines
61
to
71
| if modelCfg.ContextSize != nil { | ||
| args = append(args, "--ctx-size", strconv.FormatUint(*modelCfg.ContextSize, 10)) | ||
| } | ||
|
|
||
| // Add arguments from backend config | ||
| if config != nil { | ||
| if config.ContextSize > 0 && !containsArg(args, "--ctx-size") { | ||
| args = append(args, "--ctx-size", fmt.Sprintf("%d", config.ContextSize)) | ||
| } | ||
| args = append(args, config.RuntimeFlags...) | ||
| } |
Contributor
There was a problem hiding this comment.
I would unify the number-to-string conversion; strconv.Itoa is probably the most efficient (vs. strconv.FormatUint or fmt.Sprintf).
Contributor
Author
There was a problem hiding this comment.
I can use strconv.FormatInt and strconv.FormatUint for the backend config and artifact config respectively. strconv.Itoa accepts an int type rather than an int64. I was assuming we chose int64 in the backend config for a reason and wouldn't want to risk losing precision.
Signed-off-by: Emily Casey <[email protected]>
Signed-off-by: Emily Casey <[email protected]> Co-authored-by: Jacob Howard <[email protected]>
Signed-off-by: Emily Casey <[email protected]>
xenoscopic
approved these changes
Jun 27, 2025
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Oct 2, 2025
Enable automatic API version negotiation for the Docker client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.