No need to explicitly handle marshall of config, already handled in models/api.go

[ilopezluna]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @ilopezluna, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the JSON serialization process for model configurations by removing redundant custom marshalling logic and a dedicated raw configuration field. The change allows the standard Go JSON encoder to handle the Config field directly, simplifying the codebase, improving maintainability, and ensuring consistent serialization behavior across the application.

Highlights

• Simplified JSON Marshalling: The custom MarshalJSON method for the Model struct has been removed, simplifying the JSON serialization logic and relying on the default behavior.
• Direct Config Marshalling: The Config field within the Model struct is now directly marshaled by the standard json package by changing its tag from json:"-" to json:"config", eliminating the need for a separate RawConfig field.
• Code Cleanup in Adapters: Explicit JSON marshalling calls for the config have been removed from ToModel and ToModelFromArtifact functions in adapter.go, reducing redundancy and removing an unused import.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies the JSON marshaling of the Model struct by removing the custom MarshalJSON implementation and the redundant RawConfig field. The change leverages the standard library's default marshaling behavior for interface types, which makes the code cleaner and easier to maintain. The corresponding logic for populating RawConfig in adapter.go has been correctly removed. These changes are a significant improvement in terms of code simplicity and readability. The logic is sound and well-executed.

[sourcery-ai]

Hey - I've left some high level feedback:

• The custom UnmarshalJSON logic for Model still assumes the presence of RawConfig, so it should be updated (or simplified/removed) to align with the new Config json:"config" layout and the removal of RawConfig.
• Now that RawConfig is gone and the adapters no longer populate it, do a quick pass to remove any remaining references to RawConfig or assumptions about a separate raw payload elsewhere in the codebase to avoid nil/zero-value surprises.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The custom `UnmarshalJSON` logic for `Model` still assumes the presence of `RawConfig`, so it should be updated (or simplified/removed) to align with the new `Config json:"config"` layout and the removal of `RawConfig`.
- Now that `RawConfig` is gone and the adapters no longer populate it, do a quick pass to remove any remaining references to `RawConfig` or assumptions about a separate raw payload elsewhere in the codebase to avoid nil/zero-value surprises.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}