Added integration tests for tag command #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `cmd/cli/commands/integration_test.go:573-574` </location>
<code_context>
+ require.Equal(t, modelID, taggedModel.ID,
+ "Tagged model ID mismatch. Expected: %s, Got: %s", modelID, taggedModel.ID)
+
+ // Verify the digest matches
+ require.Equal(t, digest, taggedModel.ID,
+ "Tagged model digest mismatch. Expected: %s, Got: %s", digest, taggedModel.ID)
+
</code_context>
<issue_to_address>
**issue (testing):** Possible issue: digest is compared to model ID instead of digest.
Please confirm whether taggedModel.ID should represent the digest, or if the test should compare against a dedicated digest field. Using the wrong field may cause inaccurate test outcomes.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ericcurtin
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a comprehensive integration test for the model tagging feature in the CLI.
Note: tagging using an ID as source cases are disabled because it's not yet supported