stripDefaultsFromModelName fixed to account for default registries

[ericcurtin]

So we strip defaults fully.

[gemini-code-assist]

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the stripDefaultsFromModelName utility function to provide a more robust and comprehensive stripping of default prefixes from model names. The primary enhancement involves recognizing and removing common Docker registry prefixes, alongside improvements to how default organization prefixes and :latest tags are handled. This ensures that model names are displayed in a cleaner, more user-friendly format by fully stripping away unnecessary default components.

Highlights

• Enhanced Model Name Stripping: The stripDefaultsFromModelName function now correctly handles and removes default Docker registry prefixes (e.g., "docker.io/", "index.docker.io/") from model names.
• Refined Default Prefix Logic: The logic for stripping the defaultOrg prefix and the :latest tag has been updated to ensure full removal of defaults, even when combined with default registry prefixes.
• Expanded Test Coverage: New test cases have been added to utils_test.go to thoroughly validate the new registry stripping functionality and its interactions with existing stripping rules.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request updates stripDefaultsFromModelName to correctly handle default registries. While the new logic for registries is a good addition, the refactoring introduced a critical bug where strings.TrimPrefix was used instead of strings.TrimSuffix, which would cause incorrect behavior for some model names. Additionally, a comment in the function's documentation is misleading and should be corrected. I've provided suggestions for these issues.

[ericcurtin]

@ilopezluna ready for review