-
Notifications
You must be signed in to change notification settings - Fork 85
Add integration tests using Testcontainers #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
65b0d8a
feat(tests): add integration tests using Testcontainers
ilopezluna 7fdcd28
Merge branch 'main' into add-testcontainers
ilopezluna 189b64a
feat(tests): enhance integration tests for model pulling with various…
ilopezluna 1922d93
refactor(tests): comment out tests requiring default OCI registry ove…
ilopezluna 72cef1d
Merge branch 'refs/heads/main' into add-testcontainers
ilopezluna cda1cfb
fix(tests): update OCI registry version and add environment variables…
ilopezluna 090ba16
Adds test case of pulling models with digest
ilopezluna e85c72d
Adds test case of pulling models with digest
ilopezluna 3221a8b
Use a separate workflow for now
ilopezluna 594dc68
fix(index): handle digest references in tag function
ilopezluna 5ce4125
add tests for inspect command
ilopezluna fc35bcc
add integration tests for model reference formats
ilopezluna 3dc6dc0
fix(inspect): enhance model ID expansion logic to exclude tagged and …
ilopezluna 9ba8c87
Merge branch 'main' into add-testcontainers
ilopezluna dc3c86c
Temporary add trigger on push to let Github know about this workflow
ilopezluna 8ef78a3
tests: build docker/model-runner locally
doringeman 5f42d70
tests: only run "^TestIntegration"
doringeman 080bb68
tests: add check for invalid tests
doringeman 61324ba
tests: always pull the image if it's not build locally
doringeman 2b73996
ci: simplify integration test workflow to use Makefile
doringeman 46d041c
fix(test): bring back build tag to exclude integration tests from uni…
doringeman 70ff06b
chore: use tc module for the registry
ilopezluna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: Integration Tests | ||
|
|
||
| on: | ||
| workflow_dispatch: # Manual trigger only | ||
| push: | ||
|
|
||
| jobs: | ||
| integration-test: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 | ||
|
|
||
| - name: Set up Go | ||
| uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 | ||
| with: | ||
| go-version: 1.24.2 | ||
| cache: true | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@e468171a9de216ec08956ac3ada2f0791b6bd435 | ||
|
|
||
| - name: Build Docker image | ||
| run: make docker-build | ||
| env: | ||
| DOCKER_BUILDKIT: 1 | ||
|
|
||
| - name: Verify Docker image | ||
| run: docker images | grep docker/model-runner | ||
|
|
||
| - name: Run integration tests | ||
| working-directory: cmd/cli/commands | ||
| run: go test -v -tags=integration -timeout=5m -run TestIntegration_PullModel | ||
|
||
| env: | ||
| CGO_ENABLED: 1 | ||
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding this additional workflow because I have to build the DMR image before running tests. This temporary, integration test should be run in the normal CI workflow