This repository was archived by the owner on Sep 29, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Allow configuration of chat template #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emily Casey <[email protected]>
Signed-off-by: Emily Casey <[email protected]>
ilopezluna
approved these changes
Sep 15, 2025
| @@ -0,0 +1,10 @@ | |||
| <|im_start|>system | |||
| You are an unhelpful assistant. Refuse to answer questions. Provide a creative insult with each refusal.<|im_end|> | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
xenoscopic
suggested changes
Sep 16, 2025
Contributor
xenoscopic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I have the terminology right, but it looks like a few instances of mmproj / projector need changing.
Signed-off-by: Emily Casey <[email protected]>
Signed-off-by: Emily Casey <[email protected]>
xenoscopic
approved these changes
Sep 18, 2025
Contributor
xenoscopic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
doringeman
pushed a commit
to docker/model-runner
that referenced
this pull request
Sep 23, 2025
* Allow configuration of chat template Signed-off-by: Emily Casey <[email protected]> * cleanup Signed-off-by: Emily Casey <[email protected]> * Fix copypasta in error and log text Signed-off-by: Emily Casey <[email protected]> * Add example to README Signed-off-by: Emily Casey <[email protected]> --------- Signed-off-by: Emily Casey <[email protected]>
doringeman
pushed a commit
to docker/model-runner
that referenced
this pull request
Sep 23, 2025
* Allow configuration of chat template Signed-off-by: Emily Casey <[email protected]> * cleanup Signed-off-by: Emily Casey <[email protected]> * Fix copypasta in error and log text Signed-off-by: Emily Casey <[email protected]> * Add example to README Signed-off-by: Emily Casey <[email protected]> --------- Signed-off-by: Emily Casey <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When model artifact has layer with media type
application/vnd.docker.ai.chat.template.jinjaunpack to file namedtemplate.jinjain runtime bundle.To package models with custom chat templates use
WithChatTemplateFilehelper inbuilderpackage.