This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Normalize Hugging Face Model names to lowercase #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiview
approved these changes
Apr 29, 2025
kiview
reviewed
Apr 29, 2025
doringeman
reviewed
Apr 29, 2025
Collaborator
doringeman
left a comment
doringeman
left a comment
There was a problem hiding this comment.
func (c *Client) InspectOpenAI requires to normalize the model name as well.
doringeman
approved these changes
Apr 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes convert any Hugging Face model names (prefixed with
hf.co/) to lowercase.Repositories in Hugging Face do not follow the naming specifications defined in OCI Distribution Spec so model-distribution will fail to parse the model reference.
Ideally we should add the workaround in the model-distribution itself, but for now the fix is included in the cli because it does not require a DD release