Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Conversation

@doringeman
Copy link
Collaborator

Without this patch, we were copying the Docker config inside the docker/model-runner container running in Docker Desktop, and this made methods like pull fail due to the missing docker-credential-desktop.

$ _MODEL_RUNNER_TREAT_DESKTOP_AS_MOBY=1 docker model run ai/smollm2
Unable to find model 'ai/smollm2' locally. Pulling from the server.
Failed to pull model: pulling ai/smollm2 failed with status 500 Internal Server Error: error while pulling model: reading model from registry: failed to pull model "ai/smollm2": UNKNOWN - error getting credentials - err: exec: "docker-credential-desktop": executable file not found in $PATH, out: ``

Now everything works as expected:

$ _MODEL_RUNNER_TREAT_DESKTOP_AS_MOBY=1 docker model install-runner
latest: Pulling from docker/model-runner Digest: sha256:00fba948428db7f9a750a7a74b3af55ab99801d0a6f1a1d7b68169a948661342
Status: Image is up to date for docker/model-runner:latest

Successfully pulled docker/model-runner:latest
Starting model runner container docker-model-runner...
$ _MODEL_RUNNER_TREAT_DESKTOP_AS_MOBY=1 docker model pull ai/smollm2
Downloaded 270.60MB of 270.60MB
Model pulled successfully
$ _MODEL_RUNNER_TREAT_DESKTOP_AS_MOBY=1 docker model ls
MODEL NAME  PARAMETERS  QUANTIZATION    ARCHITECTURE  MODEL ID      CREATED       SIZE
ai/smollm2  361.82 M    IQ2_XXS/Q4_K_M  llama         354bf30d0aa3  5 months ago  256.35 MiB

Copy link
Contributor

@xenoscopic xenoscopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we get too many more _MODEL_RUNNER_TREAT_DESKTOP_AS_MOBY checks in the code, we might want to abstract it somewhere else into some sort of utility function, but I think this takes us to three checks and that's probably fine.

@doringeman doringeman merged commit 445e0fa into main Aug 27, 2025
7 checks passed
@doringeman doringeman deleted the skip-docker-config-in-dd-as-moby branch August 27, 2025 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants