ci: add a validate-tests bake target #145
Conversation
This enables running unit tests in pull requests and after merging to main or tagging a new release.
Dockerfile
Outdated
| WORKDIR /src | ||
| RUN --mount=target=. \ | ||
| --mount=target=/root/.cache,type=cache \ | ||
| CGO_ENABLED=1 go test -race -v ./... |
There was a problem hiding this comment.
Why not make unit-tests?
There was a problem hiding this comment.
Good question! make unit-tests does not call the tests with the race detector enabled (which can catch some issues), and I was afraid to change it and break something else that I was missing (enabling the race detector requires cgo and gcc). Happy to change the unit-tests target and use it if there are no objections.
There was a problem hiding this comment.
Thanks for the explanation! I didn't know enabling race detector requires cgo and gcc. I vote to merge it now then, as it's already an improvement.
Once we are confident that using make unit-tests will not break something else we can add a follow up pr
There was a problem hiding this comment.
As discussed, we've decided that adding the race detector was safe enough to do it in this PR. Thanks for the feedback!
4 participants
This enables running unit tests in pull requests and after merging
to main or tagging a new release.