Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Conversation

@ericcurtin
Copy link
Contributor

So we can do things like this:

$ cat main.go | ./model-cli run ai/smollm2 Explain this file:

other tools allow this.

@ericcurtin
Copy link
Contributor Author

@p1-0tr @xenoscopic @ilopezluna PTAL. Could someone click the build button for me please to check this passes?

Copy link
Contributor

@xenoscopic xenoscopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the stdin support, I'm not sure where I land on the multi-arg concatenation, but I guess it does allow more "natural" usage maybe, I just worry it might constrain future CLI changes where we want to use positional arguments for something else. Maybe @mia-docker can comment.

@ericcurtin
Copy link
Contributor Author

ericcurtin commented Aug 21, 2025

I like the stdin support, I'm not sure where I land on the multi-arg concatenation, but I guess it does allow more "natural" usage maybe, I just worry it might constrain future CLI changes where we want to use positional arguments for something else. Maybe @mia-docker can comment.

I'm taking influence from RamaLama and Ollama, both allows unlimited prompt args

So we can do things like this:

$ cat main.go | ./model-cli run ai/smollm2 Explain this file:

other tools allow this.

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin
Copy link
Contributor Author

Suggested changes complete and repushed

@ericcurtin
Copy link
Contributor Author

Need approval for a build again

@p1-0tr p1-0tr requested a review from xenoscopic August 22, 2025 08:14
@ericcurtin
Copy link
Contributor Author

@p1-0tr @xenoscopic anything we can do to move this along?

@p1-0tr
Copy link

p1-0tr commented Aug 27, 2025

I'd be happy to merge this, but I'll let @xenoscopic have the last word.

Copy link
Contributor

@xenoscopic xenoscopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay!

@xenoscopic xenoscopic merged commit b331608 into docker:main Aug 27, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants