-
Notifications
You must be signed in to change notification settings - Fork 16
Allow stdin and multiple prompt args #139
Conversation
|
@p1-0tr @xenoscopic @ilopezluna PTAL. Could someone click the build button for me please to check this passes? |
xenoscopic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the stdin support, I'm not sure where I land on the multi-arg concatenation, but I guess it does allow more "natural" usage maybe, I just worry it might constrain future CLI changes where we want to use positional arguments for something else. Maybe @mia-docker can comment.
I'm taking influence from RamaLama and Ollama, both allows unlimited prompt args |
So we can do things like this: $ cat main.go | ./model-cli run ai/smollm2 Explain this file: other tools allow this. Signed-off-by: Eric Curtin <[email protected]>
|
Suggested changes complete and repushed |
|
Need approval for a build again |
|
@p1-0tr @xenoscopic anything we can do to move this along? |
|
I'd be happy to merge this, but I'll let @xenoscopic have the last word. |
xenoscopic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the delay!
So we can do things like this:
$ cat main.go | ./model-cli run ai/smollm2 Explain this file:
other tools allow this.