This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Add a readme for clarity #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
approved these changes
Jul 31, 2025
Contributor
|
This is nice info. The Apache license isn't very useful reading compared to this. |
Contributor
|
@p1-0tr @xenoscopic @doringeman how can an external contributor get things reviewed? |
xenoscopic
suggested changes
Aug 20, 2025
Contributor
xenoscopic
left a comment
xenoscopic
left a comment
There was a problem hiding this comment.
Sorry for the review delay, we've had a lot of PTO and additional internal projects temporarily reducing our bandwidth (but it should now improve). I think there's a few things to adjust here (addressed individually below).
Contributor
Author
|
I have added the requested changes. Thank you for taking a look. |
xenoscopic
approved these changes
Aug 20, 2025
Contributor
xenoscopic
left a comment
xenoscopic
left a comment
There was a problem hiding this comment.
LGTM - @docker/ai-models-infra any objection to merging? (If not, I'll push the button tomorrow morning)
Contributor
|
Thanks again for the contribution! |
Contributor
Author
|
Yay! Happy to contribute! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a readme for project clarity