This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Improve progress message #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doringeman
approved these changes
Jul 4, 2025
Collaborator
doringeman
left a comment
doringeman
left a comment
There was a problem hiding this comment.
LGTM! Tested and I can't reproduce the bug anymore, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: docker/model-runner#99
Include total in progress message.
The model-distribution do not report the accumulated progress per layer.
For example, if a model contain 2 layers of 10 bytes each, and you have already pulled one of the layers, and you get a progress message for the next byte, the message received but model distribution will be like:
{"type":"progress","total":20,"pulled":1,"layer":{"ID":"layer-id-2","Size":10,"Current":1}}From this message the client do not have any way to understand the real progress 11 bytes of 20 bytes.
Because of that I keep track of the progress per layer in this PR.
Ideally this should be calculated in model-distribution but I don't know how to do it without a big change set.