Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Clean up standalone container startup using Moby idioms #107

Merged
xenoscopic merged 5 commits into from
Jun 27, 2025
Merged

Clean up standalone container startup using Moby idioms #107

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d119b50
Use correct containerd error detection.
xenoscopic Jun 18, 2025
5900e78
simplify container start logic, taking advantage of idempotency
thaJeztah Jun 19, 2025
97a5347
Clean up a few bits post-rebase and don't return on nil error.
xenoscopic Jun 20, 2025
5871b6f
Allow EOF errors to pass silently on ContainerStart.
xenoscopic Jun 20, 2025
40ba102
Rename waitForContainerToStart to ensureContainerStarted
xenoscopic Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/standalone/containers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"context"
"errors"
"fmt"
"io"
"os"
"strconv"
"strings"
Expand Down Expand Up @@ -192,7 +193,11 @@ func waitForContainerToStart(ctx context.Context, dockerClient client.ContainerA
// until the polling time out - unfortunately we can't make the 404
// acceptance window any smaller than that because the CUDA-based
// containers are large and can take time to create).
if !errdefs.IsNotFound(err) {
//
// For some reason, this error case can also manifest as an EOF on the
// request (I'm not sure where this arises in the Moby server), so we'll
// let that pass silently too.
if !(errdefs.IsNotFound(err) || errors.Is(err, io.EOF)) {
Comment on lines +198 to +201
Copy link
Member

@thaJeztah thaJeztah Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still interested in this situation; something we should look into to see what's causing this (as it seems unexpected).

return err
}
if i > 1 {
Expand Down