This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Temporarily disable credential configuration copying #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying a config.json with a "credsStore": "desktop" entry will cause invocation of the non-existent docker-credential-desktop in remote environments (e.g. CE and Cloud). I'm not sure how to work around this, but right now it disables pulls for public, non-"ai/" repositories. I'm also not sure how to make `copyDockerConfigToContainer` safe for concurrent installs, but that's a separate issue. Signed-off-by: Jacob Howard <[email protected]>
p1-0tr
approved these changes
Jun 24, 2025
ilopezluna
approved these changes
Jun 25, 2025
doringeman
approved these changes
Jun 26, 2025
Collaborator
doringeman
left a comment
doringeman
left a comment
There was a problem hiding this comment.
Sure, but don't we want to remove the function as well?
Contributor
Author
|
Closing in favor of #105 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying a
config.jsonwith a"credsStore": "desktop"entry will cause invocation of the (local-only)docker-credential-desktopin remote environments (e.g. CE and Cloud).I'm not sure how to work around this, but right now the code breaks pulls for public, non-"ai/" repositories from Cloud environments.
I'm also not sure how to make
copyDockerConfigToContainersafe for concurrent installs, but that's a separate issue.I've left the supporting code in-place for now, but I think we should triage this until @ilopezluna returns.
This didn't go out with v0.1.30 so there's no rush to find a workaround. Perhaps we disable it if the local environment is Docker Desktop? Cloud might be the only scenario where that's the case.