Skip to content

build: rename build-output to output #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazy-max merged 1 commit into from
Nov 12, 2025
Merged

build: rename build-output to output #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ jobs:
packages: write
id-token: write
with:
output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
meta-images: |
public.ecr.aws/q3b5f1u4/test-docker-action
meta-tags: |
type=raw,value=ghbuilder-single-${{ github.run_id }}
build-file: test/hello.Dockerfile
build-output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
build-sbom: true
secrets:
registry-auths: |
Expand All @@ -45,12 +45,12 @@ jobs:
packages: write
id-token: write
with:
output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
meta-images: |
public.ecr.aws/q3b5f1u4/test-docker-action
meta-tags: |
type=raw,value=ghbuilder-${{ github.run_id }}
build-file: test/hello.Dockerfile
build-output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
build-sbom: true
build-platforms: linux/amd64,linux/arm64
secrets:
Expand All @@ -66,11 +66,11 @@ jobs:
packages: write
id-token: write
with:
output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
meta-images: ghcr.io/docker/github-builder-test
meta-tags: |
type=raw,value=${{ github.run_id }}
build-file: test/hello.Dockerfile
build-output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
build-sbom: true
build-platforms: linux/amd64,linux/arm64
secrets:
Expand All @@ -86,11 +86,11 @@ jobs:
packages: write
id-token: write
with:
output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
meta-images: registry-1-stage.docker.io/docker/github-builder-test
meta-tags: |
type=raw,value=${{ github.run_id }}
build-file: test/hello.Dockerfile
build-output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
build-sbom: true
build-platforms: linux/amd64,linux/arm64
secrets:
Expand All @@ -106,11 +106,11 @@ jobs:
packages: write
id-token: write
with:
output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
meta-images: registry-1-stage.docker.io/docker/github-builder-test
meta-tags: |
type=raw,value=${{ github.run_id }},prefix=oidc-
build-file: test/hello.Dockerfile
build-output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
build-sbom: true
build-platforms: linux/amd64,linux/arm64
secrets:
Expand All @@ -125,13 +125,13 @@ jobs:
packages: write
id-token: write
with:
output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
meta-images: |
ghcr.io/docker/github-builder-test
public.ecr.aws/q3b5f1u4/test-docker-action
meta-tags: |
type=raw,value=${{ github.run_id }},prefix=ghcr-and-aws-
build-file: test/hello.Dockerfile
build-output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
build-sbom: true
build-platforms: linux/amd64,linux/arm64
secrets:
Expand All @@ -150,7 +150,7 @@ jobs:
packages: write
id-token: write
with:
output: ${{ github.event_name != 'pull_request' && 'local' || 'cacheonly' }}
build-file: test/hello.Dockerfile
build-output: ${{ github.event_name != 'pull_request' && 'local' || 'cacheonly' }}
build-sbom: true
build-platforms: linux/amd64,linux/arm64
28 changes: 15 additions & 13 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ name: build
on:
workflow_call:
inputs:
output:
type: string
description: "Build output destination (one of cacheonly, registry, local)"
default: 'cacheonly'
required: false
cache:
type: boolean
description: "Enable cache to GitHub Actions cache backend"
Expand Down Expand Up @@ -71,11 +76,6 @@ on:
type: string
description: "List of metadata for an image"
required: false
build-output:
type: string
description: "Build output destination (one of cacheonly, registry, local)"
default: 'cacheonly'
required: false
build-platforms:
type: string
description: "List of target platforms to build"
Expand Down Expand Up @@ -125,7 +125,7 @@ jobs:
-
name: Docker meta
id: meta
if: ${{ inputs.build-output == 'registry' }}
if: ${{ inputs.output == 'registry' }}
uses: docker/metadata-action@v5
with:
images: ${{ inputs.meta-images }}
Expand All @@ -142,7 +142,7 @@ jobs:
INPUT_CACHE: ${{ inputs.cache }}
INPUT_CACHE-MODE: ${{ inputs.cache-mode }}
INPUT_META-IMAGES: ${{ inputs.meta-images }}
INPUT_BUILD-OUTPUT: ${{ inputs.build-output }}
INPUT_BUILD-OUTPUT: ${{ inputs.output }}
INPUT_BUILD-ANNOTATIONS: ${{ inputs.build-annotations }}
INPUT_SET-META-ANNOTATIONS: ${{ inputs.set-meta-annotations }}
INPUT_META-ANNOTATIONS: ${{ steps.meta.outputs.annotations }}
Expand Down Expand Up @@ -211,7 +211,7 @@ jobs:
buildkitd-flags: --debug
-
name: Login to registry
if: ${{ inputs.build-output == 'registry' }}
if: ${{ inputs.output == 'registry' }}
# TODO: switch to docker/login-action when OIDC is supported
uses: crazy-max/docker-login-action@dockerhub-oidc
with:
Expand Down Expand Up @@ -240,6 +240,7 @@ jobs:
BUILDKIT_MULTI_PLATFORM: 1
-
name: Install @docker/actions-toolkit
if: ${{ inputs.output != 'cacheonly' }}
uses: actions/github-script@v8
env:
INPUT_DAT-MODULE: ${{ env.DOCKER_ACTIONS_TOOLKIT_MODULE }}
Expand All @@ -248,6 +249,7 @@ jobs:
await exec.exec('npm', ['install', '--prefer-offline', '--no-audit', core.getInput('dat-module')]);
-
name: Install Cosign
if: ${{ inputs.output != 'cacheonly' }}
uses: actions/github-script@v8
env:
INPUT_COSIGN-VERSION: ${{ env.COSIGN_VERSION }}
Expand All @@ -264,7 +266,7 @@ jobs:
await cosign.printVersion();
-
name: Signing attestation manifests
if: ${{ inputs.build-output == 'registry' }}
if: ${{ inputs.output == 'registry' }}
uses: actions/github-script@v8
env:
INPUT_IMAGE-NAMES: ${{ inputs.meta-images }}
Expand All @@ -288,7 +290,7 @@ jobs:
);
-
name: Signing local artifacts
if: ${{ inputs.build-output == 'local' }}
if: ${{ inputs.output == 'local' }}
uses: actions/github-script@v8
env:
INPUT_LOCAL-OUTPUT-DIR: ${{ env.LOCAL_EXPORT_DIR }}
Expand All @@ -309,7 +311,7 @@ jobs:
);
-
name: Create manifest
if: ${{ inputs.build-output == 'registry' }}
if: ${{ inputs.output == 'registry' }}
uses: actions/github-script@v8
env:
INPUT_IMAGE-NAMES: ${{ inputs.meta-images }}
Expand All @@ -333,12 +335,12 @@ jobs:
}
-
name: List local output
if: ${{ inputs.build-output == 'local' }}
if: ${{ inputs.output == 'local' }}
run: |
tree -nh ${{ env.LOCAL_EXPORT_DIR }}
-
name: Upload artifact
if: ${{ inputs.build-output == 'local' }}
if: ${{ inputs.output == 'local' }}
uses: actions/upload-artifact@v5
with:
name: docker-github-builder-assets
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ on:
id-token: write # for signing attestation manifests with GitHub OIDC Token
packages: write # needed to push images to GitHub Container Registry
with:
output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
meta-images: name/app
meta-tags: |
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
build-output: ${{ github.event_name != 'pull_request' && 'registry' || 'cacheonly' }}
build-platforms: linux/amd64,linux/arm64
secrets:
registry-auths: |
Expand Down