Skip to content

Conversation

@craig-osterhout
Copy link
Collaborator

@craig-osterhout craig-osterhout commented Jan 21, 2026

Updating app to remove vulnerabilities.

Requires updates to docker/docs: docker/docs#24003

Related issue: docker/docs#23988
Closes #93

Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajeetraina
Copy link

ajeetraina commented Jan 24, 2026

@craig-osterhout I noticed the updated package.json is missing the scripts section and devDependencies.

This will break Parts 5 (Bind Mounts), 6 (Multi-container apps), and 7 (Docker Compose) of the workshop, which all rely on npm run dev for hot-reloading with nodemon.

Can we add back:

"scripts": {
  "dev": "nodemon -L src/index.js"
},
"devDependencies": {
  "nodemon": "^3.1.9"
}

Without this, users following the workshop will get:

npm error Missing script: "dev"

I've tested this locally and confirmed the error occurs.

The final package.json should look like:

{
  "name": "101-app",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "scripts": {
    "dev": "nodemon -L src/index.js"
  },
  "dependencies": {
    "express": "^5.2.1",
    "mysql2": "^3.16.1",
    "sqlite3": "^5.1.7",
    "uuid": "^13.0.0",
    "wait-port": "^1.1.0"
  },
  "devDependencies": {
    "nodemon": "^3.1.9"
  },
  "overrides": {
    "tar": "7.5.4",
    "glob": "11.1.0",
    "semver": "7.5.2",
    "cross-spawn": "7.0.5",
    "braces": "3.0.3",
    "http-cache-semantics": "4.1.1",
    "socks": "2.8.1"
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

120 app vulnerabilities in example

4 participants