chore: enable extra-rules from gofumpt and paramTypeCombine from go-critic #13141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ritic Signed-off-by: Matthieu MOREL <[email protected]>
ndeloof
reviewed
Sep 29, 2025
There was a problem hiding this comment.
IHMO combined parameters types make sense when they are related, like prefix, suffix string but are more confusing when parameters have same type by change but unrelated roles, like registry, credentials string. So I'd prefer we don't enforce such a rule.
Any reason you want those set ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Enable extra-rules from gofumpt and paramTypeCombine from go-critic
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did