Skip to content

swarm: revert compose/stack support for memory swappiness #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 3 commits into from
Nov 10, 2025
Merged

swarm: revert compose/stack support for memory swappiness #6642

thaJeztah merged 3 commits into from
Nov 10, 2025
+10 −722

Conversation

@vvoland
Copy link
Collaborator

@vvoland vvoland commented Nov 10, 2025 •
edited
Loading

@vvoland vvoland added this to the 29.0.0 milestone Nov 10, 2025
@vvoland vvoland self-assigned this Nov 10, 2025
@vvoland vvoland added area/swarm kind/refactor PR's that refactor, or clean-up code labels Nov 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah mentioned this pull request Nov 10, 2025
Open
thaJeztah
thaJeztah approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

thaJeztah commented Nov 10, 2025

This keeps support on docker service create / docker service update, but (temporarily) removes support from docker stack deploy (through the compose file), until it landed in the compose-spec and we decided on naming and where the options should go.

@thaJeztah thaJeztah merged commit 31d1a59 into docker:master Nov 10, 2025
109 of 110 checks passed
@lawrsp
Copy link

lawrsp commented Nov 12, 2025

why reverted this？ Is there another way to config the memory swap /swappiness in docker stack？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

@vvoland vvoland

Labels

area/swarm kind/refactor PR's that refactor, or clean-up code

Projects

None yet

Milestone

29.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vvoland @codecov-commenter @thaJeztah @lawrsp