-
Notifications
You must be signed in to change notification settings - Fork 2.1k
image/list: Show collapsed tree by default #6566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
With graphdrivers we'll always get the Should we get #5771 in? |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
25d0a78 to
735d8ab
Compare
c5cdb8f to
bd5cebd
Compare
Nevermind; found your other PR 🤗 |
|
Hmmm, except the content size looks wrong |
Use the new tree view by default and only fallback if format or old view-related options are used. The expanded view is shown when `--tree` is passed. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
By default cobra inherit the `os.Args` if there's no non-nil Args slice set. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better
LGTM
|
In the official documentation (https://docs.docker.com/reference/cli/docker/image/ls/), if I want to list the most recent images I should do: $ docker images But after Docker version 29.0.0, I get something quite different from the documentation, as shown below: To get the expected result I need to do: $ docker image list --format "table {{.Repository}}\t{{.Tag}}\t{{.ID}}\t{{.CreatedSince}}\t{{.Size}}" This behavior is only happening to me. |
…ker images` Docker CLI 29 changed the default format of `docker images` and now merges together the label and tag of each image. This is the "tree" format introduced by commit docker/cli@c41815f ("image/list: Show collapsed tree by default") with Pull Request docker/cli#6566 ("image/list: Show collapsed tree by default"). Using `docker images --format=table` makes the command show the table again. Moreover, according to the documentation on https://docs.docker.com/reference/cli/docker/image/ls/ using option `--no-trunc` prevents truncation in columns. And using `--all` is now required to see untagged images, according to docker/cli#6574 ("image/list: Hide untagged images without --all")







Use the new tree view by default and only fallback if format or old view-related options are used.
The expanded view is shown when
--treeis passed.- Human readable description for the release notes
With containerd
With graphdrivers