build(deps): bump codecov/codecov-action from 4 to 5 #5636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
FWIW: I have not yet looked into the "token-less" upload. It looks like that doesn't automatically work on protected branches, so may need some looking at; #5620 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5636 +/- ##
=======================================
Coverage 59.49% 59.49%
=======================================
Files 346 346
Lines 29371 29371
=======================================
Hits 17474 17474
Misses 10922 10922
Partials 975 975
|
thaJeztah
commented
Nov 19, 2024
| uses: codecov/codecov-action@v5 | ||
| with: | ||
| file: ./build/coverage/coverage.txt | ||
| files: ./build/coverage/coverage.txt |
Member
Author
There was a problem hiding this comment.
Files takes a comma-separated list.. bit of an odd choice for this (not sure why they didn't pick an array / slice)
Member
Author
|
Ah! Hitting that issue that should be fixed through #5631 |
crazy-max
approved these changes
Nov 19, 2024
Benehiko
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps codecov/codecov-action from 4 to 5.
updated-dependencies:
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)