Skip to content

Conversation

@thaJeztah
Copy link
Member

relates to:

No work has started yet on the deprecation, so extending the time- window.

- A picture of a cute animal (not mandatory but encouraged)

No work has started yet on the deprecation, so extending the time-
window.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 27.0.0 milestone Jun 12, 2024
@thaJeztah thaJeztah requested a review from a team as a code owner June 12, 2024 11:44
@thaJeztah thaJeztah self-assigned this Jun 12, 2024
@thaJeztah
Copy link
Member Author

This test is really flaky or there's some bug lurking somewhere;

#20 65.15 === FAIL: cli/connhelper/commandconn TestCloseRunningCommand (5.00s)
#20 65.15     commandconn_unix_test.go:57: assertion failed: 5 (int) != 0 (n int)
#20 65.15     commandconn_unix_test.go:58: assertion failed: error is not nil: write |1: broken pipe
#20 65.15     commandconn_unix_test.go:69: test did not finish in time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.73%. Comparing base (70118ae) to head (e9c0fc3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5150      +/-   ##
==========================================
- Coverage   61.76%   61.73%   -0.04%     
==========================================
  Files         297      294       -3     
  Lines       20761    20756       -5     
==========================================
- Hits        12824    12813      -11     
- Misses       7021     7024       +3     
- Partials      916      919       +3     

@thaJeztah thaJeztah merged commit 540b28e into docker:master Jun 12, 2024
@thaJeztah thaJeztah deleted the extend_non_tls_api_deprecation branch June 12, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants