imagetools: avoid excessive HTTP requests on create #3623
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently needed manifests were filtered out and then copied in a loop, but for each copy still the full unfiltered descriptor was copied instead of single manifest, resulting multiple push attempts for same descriptor. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
When creating resulting image index it is wasteful to check for attestations for the descriptors in original index what were already attestation for subject manifest. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
If multiple tags are specified for the same repo, it is wasteful to use them as separate targets and better to make them share the blob upload phase of the push. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Member
Author
|
Added one more optimization for the case where multiple destination tags are set. |
thaJeztah
reviewed
Jan 23, 2026
| if err := eg2.Wait(); err != nil { | ||
| return err | ||
| } | ||
| ctx = withMediaTypeKeyPrefix(ctx) // because of containerd bug this needs to be called separately for each ctx/goroutine pair to avoid concurrent map write |
Member
There was a problem hiding this comment.
Off-topic, but is there a ticket related to this so that we can track if it's still needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two separate fixes to avoid bombarding registry with extra requests.
Potential follow-ups for the next feature release:
referrerscommand.