buildx(install): use sigstore module to verify signature #929
+145
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
commented
Jan 12, 2026
src/buildx/install.ts
Outdated
| const signedEntity = toSignedEntity(bundle, fs.readFileSync(binPath)); | ||
| const verifier = new Verifier(trustMaterial); | ||
| const signer = verifier.verify(signedEntity, { | ||
| subjectAlternativeName: /^https:\/\/github\.com\/docker\/(github-builder-experimental|github-builder)\/\.github\/workflows\/build\.yml.*$/, |
Member
Author
There was a problem hiding this comment.
Regexp not supported like cosign:
actions-toolkit/src/sigstore/sigstore.ts
Line 147 in 22773fa
Opened sigstore/sigstore-js#1556
28 tasks
crazy-max
force-pushed
the
buildx-verify
branch
13 times, most recently
from
13330f9 to
01bd355
Compare
crazy-max
force-pushed
the
buildx-verify
branch
from
a27376c to
b90bb7b
Compare
tonistiigi
reviewed
Jan 27, 2026
__tests__/buildx/install.test.itg.ts
Outdated
| maybe('download', () => { | ||
| // prettier-ignore | ||
| test.each(['latest'])( | ||
| test.each(['v0.31.0-rc1'])( |
Member
Author
There was a problem hiding this comment.
Ah yes let me change that
crazy-max
force-pushed
the
buildx-verify
branch
from
b90bb7b to
81e3c15
Compare
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
buildx-verify
branch
from
81e3c15 to
17e08b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to docker/github-builder-experimental#74