-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[ROS] Update Official Docker image docs #2578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
as final ROS 1 version, Noetic, is now EOL
as docs page is more up-to-date and pertinent for users
to avoid docs from becoming stale
as example to save on image size as well as on build time using caching
for readability of each stage
and update rosdep along with apt list to ensure package index is fresh
to include additional relevant entries
to focus on primary targets
accounting for included docker-clean default
to avoid running rosdep update for each source change as docker build --no-cache can still be used to force update
@mikaelarguedas or @tfoote , could you take a look this? Think it's about ready to go. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It generally looks like a good improvement. The naming of installer versus runner seem a little bit confusing to me. I feel like installer might be clearer with a name more like "upstream" or "prebuilt" maybe.
looks great overall ! agreed with Tully's comment maybe using |
while keeping with uniquely spelled noun that is self descriptive yet unmistakable
For reproducibility, I'd generally like to discourage implicit or explicit use of Also, this exemplifies how to postfix an ARG to minimize the runtime image, and Line 113 in 5f3ac57
|
Refreshes the ROS documentation using updated links, cleans out old content, and improves the demo examples.
Related: