This repository was archived by the owner on Jun 11, 2020. It is now read-only.
[17.06] Fix memory uint64 to int64 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This vendoring brings in the change from uint64 to int64 in the Memory structs. Signed-off-by: Tibor Vass <[email protected]>
replace opencontainers#1492 opencontainers#1494 fix opencontainers#1422 Since opencontainers/runtime-spec#876 the memory specifications are now `int64`, as that better matches the visible interface where `-1` is a valid value. Otherwise finding the correct value was difficult as it was kernel dependent. Signed-off-by: Justin Cormack <[email protected]> (cherry picked from commit 3d9074e) Signed-off-by: Tibor Vass <[email protected]>
Author
|
LGTM
…On 6 Jul 2017 6:52 pm, "Tibor Vass" ***@***.***> wrote:
cc @crosbymichael <https://github.com/crosbymichael> @justincormack
<https://github.com/justincormack> @mlaventure
<https://github.com/mlaventure>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAdcPMwb7Hm_wwvj-5UEdz1huJQ5uaOFks5sLR7GgaJpZM4OP-Ps>
.
|
kolyshkin
referenced
this pull request
in kolyshkin/runc
Jul 2, 2018
VERSION: back to development VERSION: bump to v1.0.0-rc5 Votes: +5 -0 #2 LGTMs: @crosbymichael @cyphar @dqminh @hqhq @mrunalp Closes opencontainers#1739
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.